Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document settings BeforeTemplateRenderedEvent #23778

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Document settings BeforeTemplateRenderedEvent #23778

merged 1 commit into from
Oct 29, 2020

Conversation

MorrisJobke
Copy link
Member

Ref #22649

@MorrisJobke
Document settings BeforeTemplateRenderedEvent
e2e7c2d 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 29, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Oct 29, 2020
@MorrisJobke
Copy link
Member Author

nextcloud/documentation#5313

ChristophWurst
ChristophWurst approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO should be in \OCP if this is meant to be an event to consume by apps

@MorrisJobke
Copy link
Member Author

IMO should be in \OCP if this is meant to be an event to consume by apps

We have quite some other events in the OCA namespace right now. Let's tackle this then in a followup.

@rullzer rullzer merged commit 9b15b66 into master Oct 29, 2020
@rullzer rullzer deleted the doc/22649/document-settings-before-template-event branch October 29, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@blizzz blizzz Awaiting requested review from blizzz

@kesselb kesselb Awaiting requested review from kesselb

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @rullzer @ChristophWurst